-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Ecoute les évènements questions répondue et détermine si une quête est validée (PIX-13819). #10108
Merged
La-toile-cosmique
merged 12 commits into
dev
from
pix-13819-listen-to-answer-events-and-check-quest
Sep 23, 2024
Merged
[FEATURE] Ecoute les évènements questions répondue et détermine si une quête est validée (PIX-13819). #10108
La-toile-cosmique
merged 12 commits into
dev
from
pix-13819-listen-to-answer-events-and-check-quest
Sep 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frinyvonnick
added
Development in progress
team-evaluation
PR relatives à l'expérience d'évaluation
team-prescription
labels
Sep 12, 2024
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
frinyvonnick
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
2 times, most recently
from
September 12, 2024 13:33
7476d46
to
be9d439
Compare
Libouk
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
from
September 13, 2024 10:03
be9d439
to
be914b3
Compare
La-toile-cosmique
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
2 times, most recently
from
September 13, 2024 15:29
a798bff
to
7d3721a
Compare
Libouk
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
2 times, most recently
from
September 16, 2024 13:02
a96b88e
to
90edf3a
Compare
La-toile-cosmique
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
2 times, most recently
from
September 16, 2024 14:33
8e662f7
to
32a4d80
Compare
Jeyffrey
reviewed
Sep 18, 2024
...evaluation/unit/domain/usecases/find-filtered-most-recent-knowledge-elements-by-user_test.js
Outdated
Show resolved
Hide resolved
api/tests/evaluation/unit/application/api/knowlegde-elements-api_test.js
Outdated
Show resolved
Hide resolved
api/tests/evaluation/unit/application/api/knowlegde-elements-api_test.js
Outdated
Show resolved
Hide resolved
api/tests/quest/integration/infrastructure/repositories/profile-reward-repository_test.js
Outdated
Show resolved
Hide resolved
api/src/quest/domain/usecases/check-quest-eligibility-and-attribute-quests-rewards.js
Outdated
Show resolved
Hide resolved
api/src/quest/domain/usecases/check-quest-eligibility-and-attribute-quests-rewards.js
Outdated
Show resolved
Hide resolved
api/tests/quest/domain/usecases/check-quest-eligibility-and-attribute-quests-rewards_test.js
Outdated
Show resolved
Hide resolved
api/tests/quest/domain/usecases/check-quest-eligibility-and-attribute-quests-rewards_test.js
Outdated
Show resolved
Hide resolved
Jeyffrey
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
from
September 18, 2024 13:32
45386ee
to
cf9cf58
Compare
La-toile-cosmique
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
2 times, most recently
from
September 19, 2024 07:41
c9302e7
to
9da6221
Compare
Libouk
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
from
September 19, 2024 09:57
9da6221
to
96c98ed
Compare
frinyvonnick
commented
Sep 19, 2024
api/src/quest/infrastructure/repositories/profile-reward-repository.js
Outdated
Show resolved
Hide resolved
La-toile-cosmique
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
3 times, most recently
from
September 19, 2024 15:38
1e3b26b
to
522c692
Compare
Libouk
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
2 times, most recently
from
September 20, 2024 09:42
5a504cb
to
206461a
Compare
Alexandre-Monney
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
2 times, most recently
from
September 20, 2024 13:08
fef27cd
to
bfcbdbc
Compare
Revue func faite en pair, pour les différents cas possibles 👍 |
Alexandre-Monney
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
from
September 20, 2024 14:57
bfcbdbc
to
9be1052
Compare
La-toile-cosmique
approved these changes
Sep 20, 2024
Alexandre-Monney
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 🐈⬛
Alexandre-Monney
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
2 times, most recently
from
September 20, 2024 15:51
1074d00
to
45c99ce
Compare
Libouk
approved these changes
Sep 23, 2024
Jeyffrey
reviewed
Sep 23, 2024
api/tests/profile/integration/infrastructure/repositories/profile-reward-repository_test.js
Show resolved
Hide resolved
Jeyffrey
reviewed
Sep 23, 2024
api/tests/integration/infrastructure/repositories/knowledge-element-repository_test.js
Show resolved
Hide resolved
matthiasferraina
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
from
September 23, 2024 12:56
cc7072f
to
cc12586
Compare
matthiasferraina
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
from
September 23, 2024 12:58
cc12586
to
282f0b0
Compare
matthiasferraina
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
from
September 23, 2024 13:06
282f0b0
to
616811b
Compare
La-toile-cosmique
force-pushed
the
pix-13819-listen-to-answer-events-and-check-quest
branch
from
September 23, 2024 13:32
616811b
to
2c3dabc
Compare
La-toile-cosmique
deleted the
pix-13819-listen-to-answer-events-and-check-quest
branch
September 23, 2024 13:40
bpetetot
pushed a commit
that referenced
this pull request
Sep 25, 2024
…e quête est validée (PIX-13819). (#10108) Co-authored-by: Guillaume Olejniczak <[email protected]> Co-authored-by: Quentin Lebouc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Dans le cadre de l'Epix des attestations, nous souhaitons ajouter un mécanisme de gestion des événements asynchrone liés aux réponses de l'utilisateur afin de déterminer si celui ci est éligible à une quête donnée. Si tel est le cas, vérifier son obtention ou non.
Dans le cas ou l'utilisateur l'aurait obtenu, on souhaite l'enregistrer en base.
🤖 Proposition
Créer les sous domaines liés aux quêtes et aux profils.
Créer la gestion de l'évenement, avec les repository, usecases associés. Nous avons également, créer différentes API internes afin de communiquer entre les sous domaines. Et mis en place le mécanisme, qui sera lui même activé au tout dernier moment
🌈 Remarques
Peut être avons nous fais plusieurs tickets dans cette PR 🫣
💯 Pour tester