feat(api): prevent reward if user already has one

Author: Libouk

api/src/quest/domain/usecases/reward-user.js

@@ -13,13 +13,20 @@ export const rewardUser = async ({
 
   const eligibilities = await eligibilityRepository.find({ userId });
 
+  const rewards = await rewardRepository.getByUserId({ userId });
+  const rewardIds = rewards.map((reward) => reward.rewardId);
+
   for (const quest of quests) {
     const isEligibleForQuest = eligibilities.some((eligibility) => quest.isEligible(eligibility));
 
     if (!isEligibleForQuest) {
       continue;
     }
 
+    if (rewardIds.includes(quest.rewardId)) {
+      continue;
+    }
+
     const success = await successRepository.find({ userId, skillIds: quest.successRequirements[0].data.ids });
     const userHasSucceedQuest = quest.isSuccessful(success);
 

api/src/quest/infrastructure/repositories/reward-repository.js

@@ -1,3 +1,7 @@
 export const reward = async ({ userId, rewardId, profileRewardApi }) => {
   return profileRewardApi.save(userId, rewardId);
 };
+
+export const getByUserId = async ({ userId, profileRewardApi }) => {
+  return profileRewardApi.getByUserId(userId);
+};

api/tests/quest/unit/domain/usecases/reward-user_test.js

@@ -82,4 +82,29 @@ describe('Quest | Unit | Domain | Usecases | RewardUser', function () {
       expect(rewardRepository.save).to.have.not.been.called;
     });
   });
+
+  context('when the user is eligible but already got the reward', function () {
+    it('should not call success repository', async function () {
+      // given
+      const questRewardId = Symbol('questRewardId');
+      const quest = { isEligible: () => true, rewardId: questRewardId };
+      questRepository.findAll.resolves([quest]);
+      eligibilityRepository.find.resolves([Symbol('eligibility')]);
+      rewardRepository.getByUserId.resolves([
+        {
+          rewardId: questRewardId,
+        },
+      ]);
+
+      // when
+      await rewardUser({
+        userId,
+        questRepository,
+        eligibilityRepository,
+        successRepository,
+        rewardRepository,
+      });
+      expect(successRepository.find).to.not.have.been.called;
+    });
+  });
 });