-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Big optmizations to ecAdd, ecMul and ecPairing and small refactor #328
Draft
hecmas
wants to merge
12
commits into
develop-feijoa
Choose a base branch
from
feature/bn254-optz
base: develop-feijoa
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,802
−1,276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecmas
requested review from
laisolizq,
krlosMata,
invocamanman and
ignasirv
as code owners
February 5, 2024 19:01
hecmas
changed the title
Big optmizations to ecPairing and small refactor
Big optmizations to ecAdd, ecMul and ecPairing and small refactor
Feb 5, 2024
hecmas
changed the base branch from
develop-feijoa
to
feature/precompiled-optz
February 5, 2024 19:03
hecmas
changed the base branch from
feature/precompiled-optz
to
develop-feijoa
February 5, 2024 19:05
Quality Gate passedIssues Measures |
krlosMata
force-pushed
the
develop-feijoa
branch
from
March 7, 2024 12:08
a302c6a
to
f7290c3
Compare
hecmas
force-pushed
the
feature/bn254-optz
branch
from
May 30, 2024 15:54
cb4a5e6
to
d8011e4
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following significative optimizations:
ecMul.zkasm
calls toecAdd.zkasm
now to avoid unnecessary checks.doublePointBN254.zkasm
to perform doublings.ecMul.zkasm
now does not use any binary to perform the scalark
reconstruction.bitwiseReconstruction.zkasm
has been added to allow "fill in" the missing bits of a particularscalarMulBN254
, we now usescalarMulFP2BN254
to put emphasy on the underlying finite field.ecAdd
,ecMul
andecPairing
.