Merge pull request #329 from 0xPolygonHermez/feature/sub-fix

Subtraction fix
0xPolygonHermez · Feb 8, 2024 · a302c6a · a302c6a
2 parents 09b0cc3 + 7a3d075
commit a302c6a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -37,4 +37,4 @@ jobs:
         run: |
           export NUM_CPUS=31
           npm run test:start
-          sh tools/parallel-testing/checker.sh
+          sh tools/parallel-testing/checker.sh
diff --git a/main/pairings/FPBN254/subFpBN254.zkasm b/main/pairings/FPBN254/subFpBN254.zkasm
@@ -8,10 +8,16 @@
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
 subFpBN254:
+        ; 0] Negate C
+        A => D
+        %BN254_P => A
+        C => B
+        $ => C      :SUB
+        D => A
+
         ; 1] Compute and check the sub over Z
         ; A·[1] + [BN254_P-C] = [D]·2²⁵⁶ + [E]
         1 => B
-        ${const.BN254_P - C} => C
         $${var _subFpBN254_AC = A + C}
         ${_subFpBN254_AC >> 256} => D
         ${_subFpBN254_AC} => E :ARITH