Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new .get_probability() from zyte-common-items==0.12.0 #7

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

BurnzZ
Copy link
Contributor

@BurnzZ BurnzZ commented Oct 27, 2023

Following the 0.12.0 release of zyte-common-items which contains this new feature: zytedata/zyte-common-items#65

@codecov-commenter
Copy link

Codecov Report

Merging #7 (9114917) into main (755dbd8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 9114917 differs from pull request most recent head 0c97bee. Consider uploading reports for the commit 0c97bee to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
- Coverage   99.10%   99.09%   -0.02%     
==========================================
  Files           8        8              
  Lines         449      444       -5     
==========================================
- Hits          445      440       -5     
  Misses          4        4              
Files Coverage Δ
zyte_spider_templates/spiders/base.py 97.61% <100.00%> (-0.16%) ⬇️
zyte_spider_templates/spiders/ecommerce.py 94.23% <100.00%> (-0.22%) ⬇️

@BurnzZ BurnzZ force-pushed the get_probabilities branch from 0c97bee to c80e3f4 Compare October 27, 2023 13:36
@BurnzZ BurnzZ requested review from wRAR and kmike October 27, 2023 13:38
@kmike kmike merged commit d04289b into main Oct 27, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants