Fix _replace_builtin #107
Merged
Fix _replace_builtin #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wRAR
approved these changes
Dec 19, 2024
…h, not a class object
PyExplorer
approved these changes
Dec 19, 2024
|
@Gallaecio could you please add a link (or short note) to the issue that this fix is going to fix? |
|
PR description added. |
Gallaecio
commented
Dec 19, 2024
Comment on lines
73
to
+75
| MaxRequestsPerSeedDownloaderMiddleware: 100, | ||
| OffsiteMiddleware: None, | ||
| AllowOffsiteMiddleware: 500, | ||
| BUILTIN_OFFSITE_MIDDLEWARE_IMPORT_PATH: None, | ||
| AllowOffsiteMiddleware: 50, |
There was a problem hiding this comment.
As far as I can see from the code, this change in order (the offsite middleware will now come before the max-requests-per-seed middleware) is OK, probably even for the best. I hope it does not come back to bite me…
There was a problem hiding this comment.
:) It's interesting as all tests for the addon passed - might be this case was not covered :(
There was a problem hiding this comment.
The add-on was injecting the built-in middleware manually (the lines removed) before calling _replace_builtin, that’s why it was not caught by the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_replace_builtinis meant to find a component, disable it, and replace it by another with the same priority value.However, due to a variable typo I probably made myself, this function was failing to see built-in components (those in the
*_BASEsettings), so they were never disabled, causing the built-in offsite middleware to remain enabled, which in turn caused offsite request to be ignored even if allowed through meta (that only our custom middleware takes into account).