Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark job posting template as experimental #102

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

kmike
Copy link
Contributor

@kmike kmike commented Dec 13, 2024

It is useful as-is, but there are known issues - e.g. JS pagination is common on job websites, and it's not handled by the spider, so on many websites it can only extract jobs from the first page.

It is useful as-is, but there are known issues - e.g. JS pagination
is common on job websites, and it's not handled by the spider, so on
many websites it can only extract jobs from the first page.
@kmike kmike requested review from wRAR and Gallaecio December 13, 2024 19:57
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.35%. Comparing base (78c495c) to head (3367b0d).
Report is 2 commits behind head on job-posting-product-list.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           job-posting-product-list     #102   +/-   ##
=========================================================
  Coverage                     95.35%   95.35%           
=========================================================
  Files                            26       26           
  Lines                          2604     2604           
=========================================================
  Hits                           2483     2483           
  Misses                          121      121           
Files with missing lines Coverage Δ
zyte_spider_templates/spiders/job_posting.py 95.69% <ø> (ø)

@kmike kmike merged commit d4c4855 into job-posting-product-list Dec 16, 2024
11 checks passed
@wRAR wRAR deleted the mark-job-postings-as-experimental branch December 18, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants