Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection name validation #100

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

kmike
Copy link
Contributor

@kmike kmike commented Dec 13, 2024

No description provided.

@kmike kmike changed the base branch from main to articles_to_main December 13, 2024 16:13
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.38%. Comparing base (8927379) to head (ad6a58c).

Additional details and impacted files
@@                Coverage Diff                @@
##           articles_to_main     #100   +/-   ##
=================================================
  Coverage             95.38%   95.38%           
=================================================
  Files                    25       25           
  Lines                  2449     2449           
=================================================
  Hits                   2336     2336           
  Misses                  113      113           
Files with missing lines Coverage Δ
zyte_spider_templates/spiders/article.py 85.62% <ø> (ø)

@kmike kmike marked this pull request as ready for review December 13, 2024 16:20
@kmike
Copy link
Contributor Author

kmike commented Dec 13, 2024

This doesn't enable UI validation for some reason (looks like a bug - is pattern validation supported for nullable string fields in the SC UI?), but at least it fails in a spider, and also adds a suggestion to the user not to use such collection names.

@kmike
Copy link
Contributor Author

kmike commented Dec 13, 2024

I can confirm that when the field is made required, validation starts to work.

@kmike kmike merged commit 80aa641 into articles_to_main Dec 13, 2024
@wRAR wRAR deleted the fix-collection-name-validation branch December 18, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants