mentions: Make @-mentions tappable to navigate to user profiles #2075
+131
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a userId field to UserMentionNode to store the user ID extracted from the data-user-id HTML attribute during parsing. The field is nullable (int?) because: - Individual user mentions have a numeric user ID - Wildcard mentions (@ALL, @channel) have data-user-id="*" - Group mentions use data-user-group-id instead - Topic mentions don't have a user ID attribute This field will be used by the UserMention widget to enable navigation to the user's profile page when tapped.
Fixes: zulip#1867 Tapping on an @-mention of an individual user now navigates to that user's profile page, matching the behavior when tapping on a sender's name or avatar in the message list. Group mentions, wildcard mentions (@ALL, @channel), and topic mentions do not navigate, as they don't represent specific users. The UserMention widget is converted from StatelessWidget to StatefulWidget to properly manage the TapGestureRecognizer lifecycle, following the established pattern in this codebase (e.g., TextWithLink, _BlockInlineContainer).
Update all ContentExample instances for user mentions to include the userId parameter, matching the updated UserMentionNode signature. Add tests for @-mention tap behavior: - Tapping user mention navigates to profile page - Tapping group mention does not navigate - Tapping wildcard mention does not navigate - Tapping topic mention does not navigate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo:
issue1899.mp4
Closes #1867