Show archive icon for archived channels and add test (fixes #1992) #2037

nsamuelreddy · 2025-12-12T17:36:26Z

This PR updates the channel list to display an archive SVG icon for channels marked as archived.

Changes:

Shows the archive icon for archived channels and the normal icon for others
Registers the SVG asset in pubspec.yaml and places it in assets/icons/archive.svg
Adds a widget test to verify the archive icon appears for archived channels and a normal icon for non-archived channels

Testing:

Ran the new widget test to confirm correct icon display

Fixes #1992

gnprice · 2025-12-13T00:06:57Z

This PR makes a large number of extraneous changes. Please see our contributor guidelines, and revise this as best you can to be a highly reviewable PR with clear and coherent commits.

nsamuelreddy · 2025-12-13T18:34:41Z

Thanks for pointing this out. I see that the PR currently contains unrelated and generated changes. I’ll reset the branch, reapply only the archived-channel icon change, and split it into clean, reviewable commits following the contributor guidelines. I’ll post an update once done.

nsamuelreddy · 2025-12-13T19:27:53Z

Thanks! I’ve cleaned up the branch, removed the unrelated changes, and kept the PR focused on the archived-channel icon and its test. All checks are passing and the branch is now up to date.
Please let me know if any further adjustments are needed.

chrisbobbe

Thanks!

Please add the icon in a separate commit, saying where it came from. For similar commits which you can use as examples, please browse the commit history (instructions here), and be sure to format both commit messages according to the project style: https://github.com/zulip/zulip-mobile/blob/master/docs/style.md#git-commits-commit-messages

chrisbobbe · 2025-12-15T21:07:26Z

lib/widgets/all_channels.dart

              size: 20,
              color: colorSwatchFor(context, subscription).iconOnPlainBackground,
-              iconDataForStream(channel)),
+              channel.isArchived ? ZulipIcons.archive : iconDataForStream(channel)),


Let's give this responsibility to the iconDataForStream function itself.

Thanks! I’ll move the icon addition into a separate commit and include its source, and update the commit messages to follow the project style.

nsamuelreddy · 2025-12-17T16:25:15Z

Thanks for the feedback! I've updated the PR:

Split into 2 commits: one for adding the icon (with attribution), one for using it
Moved the logic to iconDataForStream() function as suggested

Please let me know if there's anything else to adjust!

chrisbobbe · 2025-12-18T22:32:11Z

Thank you! We now have a custom icon to use; please copy-paste the SVG from here and update the PR: #mobile-design > archived-channel icon @ 💬

nsamuelreddy · 2025-12-19T12:24:49Z

Thanks , I will replace it and update pr

nsamuelreddy · 2025-12-19T12:39:09Z

Thanks, I've updated the archive icon with Karl's custom SVG from the mobile-design discussion and regenerated the icon font. The PR is now updated with the custom Zulip design.

chrisbobbe

Thanks! Comments below. Please also post "before" and "after" screenshots of the change, as required; this is mentioned in our contributing guides.

chrisbobbe · 2025-12-19T20:44:24Z

lib/widgets/icons.dart

  // BEGIN GENERATED ICON DATA

+  /// The Zulip custom icon "archive".
+  static const IconData archive = IconData(0xf101, fontFamily: "Zulip Icons");


How did you create the link to the design discussion, in the commit message? The channel-ID part is wrong, so it doesn't take me to the intended message.

In the commit message, please link to the specific message that contains the SVG. Currently, it links to a message much earlier in the conversation.

chrisbobbe · 2025-12-19T20:45:50Z

lib/widgets/icons.dart

  //   see this message and the one after it:
  //   https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/design.3A.20.23F117.20.22Inbox.22.20screen/near/1680637
  return switch(stream) {
+    ZulipStream(isArchived: true) => ZulipIcons.archive,


Please don't start showing the icon in the same commit that adds the asset to the project. I mentioned this in my last review: #2037 (review)

chrisbobbe · 2025-12-19T20:47:02Z

test/widgets/all_channels_test.dart

+    final archivedIcon = tester.widgetList<Icon>(find.byType(Icon))
+      .firstWhere((icon) => icon.icon == ZulipIcons.archive);
+    check(archivedIcon).isNotNull();
+
+    final activeIcons = tester.widgetList<Icon>(find.byType(Icon))
+      .where((icon) => icon.icon != ZulipIcons.archive);
+    check(activeIcons).isNotEmpty();


Let's use check(…).findsOne() for both of these; see other tests for examples.

nsamuelreddy · 2025-12-21T08:37:04Z

Thanks for the review! I've fixed all the code issues:

Fixed the channel link (530-mobile-design)
Split commits properly - first adds icon asset, second uses it
Updated test to use check(...).findsOne() pattern
Fixed formatting for CI
For screenshots - I'm having trouble getting archived channels to sync to the app. I archived a test channel on the web, but it's not appearing in the mobile app even after restarting. The feature works correctly in the automated tests though. Any suggestions on how to get an archived channel to show up for screenshots?

chrisbobbe · 2025-12-23T20:24:23Z

For screenshots - I'm having trouble getting archived channels to sync to the app. I archived a test channel on the web, but it's not appearing in the mobile app even after restarting. The feature works correctly in the automated tests though. Any suggestions on how to get an archived channel to show up for screenshots?

One option is to make temporary code changes, to pretend that a non-archived channel is actually archived.

chrisbobbe · 2025-12-23T20:22:14Z

lib/widgets/icons.dart

  // BEGIN GENERATED ICON DATA

+  /// The Zulip custom icon "archive".
+  static const IconData archive = IconData(0xf101, fontFamily: "Zulip Icons");


In the commit message, please link to the specific message that contains the SVG. Currently, it links to a message much earlier in the conversation.

Custom archive icon provided by Karl Stolley for Zulip mobile. Design discussion: https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/archived-channel.20icon/near/2331344

nsamuelreddy · 2025-12-25T13:31:40Z

Fixed the commit message to link to Karl's specific message containing the SVG code (near/2331344).

Screenshots:

Before (current behavior - normal channel icons):
[BEFORE screenshot]

After (with this PR - archive icon on channels):
[AFTER screenshot]

The archive icon now displays correctly for archived channels.

chrisbobbe · 2025-12-30T01:20:13Z

Thanks. Could you please also post before-and-after screenshots of how this looks in the channel action sheet?

Those screenshots take a lot of vertical space when I load the page in the GitHub web app. A GitHub markdown table is a good format to post screenshots in GitHub comments. For an example, see #1999 (comment) .

nsamuelreddy · 2026-01-02T07:45:59Z

Sure, I’ll add before-and-after screenshots of the channel action sheet and format them in a GitHub Markdown table to save vertical space, like in #1999

nsamuelreddy · 2026-01-02T14:26:59Z

Screenshots (Channel action sheet)

Before	After

chrisbobbe · 2026-01-02T19:22:06Z

Those screenshots don't show the channel action sheet.

nsamuelreddy · 2026-01-06T18:33:37Z

Screenshots (Channel action sheet)

Before	After

chrisbobbe · 2026-01-06T19:47:25Z

The icon looks very slightly too high in the channel action sheet, to me; can you nudge it down just a little bit?

nsamuelreddy · 2026-01-07T03:48:27Z

Sure — I’ll nudge the archive icon down slightly in the channel action sheet and update the alignment.

Fixes: zulip#1992

nsamuelreddy · 2026-01-07T04:29:02Z

Screenshots (Channel Action Sheet)

Before	After

nsamuelreddy · 2026-01-13T12:11:47Z

Hi chrisbobbe,
Just following up on my PR regarding the icon size change. I’ve been waiting for a few days and wanted to check if it can be merged or if any changes are needed.
Thanks!

nsamuelreddy force-pushed the archived-channel-icon branch 5 times, most recently from dd9bb6a to 39fa711 Compare December 13, 2025 17:35

nsamuelreddy force-pushed the archived-channel-icon branch from 39fa711 to b6aad25 Compare December 13, 2025 19:00

nsamuelreddy mentioned this pull request Dec 14, 2025

Pin/unpin in channel action sheet #1942

Open

chrisbobbe reviewed Dec 15, 2025

View reviewed changes

nsamuelreddy force-pushed the archived-channel-icon branch from b6aad25 to 8892fd1 Compare December 17, 2025 16:08

nsamuelreddy force-pushed the archived-channel-icon branch from 8892fd1 to 23f7ab5 Compare December 19, 2025 12:37

chrisbobbe reviewed Dec 19, 2025

View reviewed changes

nsamuelreddy force-pushed the archived-channel-icon branch 3 times, most recently from 812ece9 to 32cccf5 Compare December 20, 2025 16:20

chrisbobbe requested changes Dec 23, 2025

View reviewed changes

icons: Add 'archive', custom Zulip design

0a9608e

Custom archive icon provided by Karl Stolley for Zulip mobile. Design discussion: https://chat.zulip.org/#narrow/channel/530-mobile-design/topic/archived-channel.20icon/near/2331344

nsamuelreddy force-pushed the archived-channel-icon branch from 32cccf5 to 85fa865 Compare December 25, 2025 12:19

nsamuelreddy force-pushed the archived-channel-icon branch 2 times, most recently from cb40efc to 338c1d9 Compare January 7, 2026 04:00

all_channels: Show archive icon for archived channels

338c1d9

Fixes: zulip#1992

gnprice added the maintainer review PR ready for review by Zulip maintainers label Jan 15, 2026

Show archive icon for archived channels and add test (fixes #1992) #2037

Are you sure you want to change the base?

Show archive icon for archived channels and add test (fixes #1992) #2037

Uh oh!

Conversation

nsamuelreddy commented Dec 12, 2025

Uh oh!

gnprice commented Dec 13, 2025

Uh oh!

nsamuelreddy commented Dec 13, 2025

Uh oh!

nsamuelreddy commented Dec 13, 2025

Uh oh!

chrisbobbe left a comment

Choose a reason for hiding this comment

Uh oh!

chrisbobbe Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

nsamuelreddy Dec 17, 2025

Choose a reason for hiding this comment

Uh oh!

nsamuelreddy commented Dec 17, 2025

Uh oh!

chrisbobbe commented Dec 18, 2025

Uh oh!

nsamuelreddy commented Dec 19, 2025

Uh oh!

nsamuelreddy commented Dec 19, 2025

Uh oh!

chrisbobbe left a comment

Choose a reason for hiding this comment

Uh oh!

chrisbobbe Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

chrisbobbe Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

chrisbobbe Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

chrisbobbe Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

nsamuelreddy commented Dec 21, 2025

Uh oh!

chrisbobbe commented Dec 23, 2025

Uh oh!

chrisbobbe Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

nsamuelreddy commented Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrisbobbe commented Dec 30, 2025

Uh oh!

nsamuelreddy commented Jan 2, 2026

Uh oh!

nsamuelreddy commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Screenshots (Channel action sheet)

Uh oh!

chrisbobbe commented Jan 2, 2026

Uh oh!

nsamuelreddy commented Jan 6, 2026

Screenshots (Channel action sheet)

Uh oh!

chrisbobbe commented Jan 6, 2026

Uh oh!

nsamuelreddy commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nsamuelreddy commented Jan 7, 2026

Screenshots (Channel Action Sheet)

Uh oh!

nsamuelreddy commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

nsamuelreddy commented Dec 25, 2025 •

edited

Loading

nsamuelreddy commented Jan 2, 2026 •

edited

Loading

nsamuelreddy commented Jan 7, 2026 •

edited

Loading

nsamuelreddy commented Jan 13, 2026 •

edited

Loading