-
Notifications
You must be signed in to change notification settings - Fork 328
Fixes #1808: Added UI Feedback on Poll Delay #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @MritunjayTiwari14,
Let's fix up the commit message by following the commit style guidelines.
Something like:
poll: Display UI feedback on poll delay.
<description>
Fixes: #1808
Might be a better way to write this.
Feel free to add details and helpful info in the commit description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting a thread in the #mobile-design channel might be useful to gain initial feedback on this.
We replaced the unawaited call to sendSubmessage() with an awaited call. This ensures that the operation's start and completion can be tracked, which makes it possible to implement a loading indicator. With the previous unawaited behavior, there was no reliable way to measure the duration of the process. Fixes: zulip#1808
b87d1bb
to
3ddc690
Compare
Thank you very much for Reviewing! @apoorvapendse |
Okay, I will look forward into this Channel for further feedback. |
Cool, let's line wrap the description to <= 70 characters per line. |
If we show a spinner, I'd expect it to appear on the poll, not blocking the user from reading their other messages. |
I will make sure to use line wrap in the Description from Now, thank you. |
Okay, I’ll work on implementing a spinner similar to the Zulip web poll system. |
Pull Request: [Circular Loading Indicator Implementation](polls: Add UI feedback on vote button while request pending #1808)
Hello Moderators of Zulip Flutter,
This is Mritunjay Tiwari.
This is my first ever contribution to Zulip.
📌 My Solution
Implementation Video and Images
record.mp4
I have researched for many days about the best practices to implement a Circular Loading Indicator.
At the end, I found that it is very hard and not efficient to implement a progress indicator for an unawaited process on which the pull request depends.
So, I came up with an efficient solution:
by converting the unawaited process to an awaited process, we can easily capture the loading state and then implement a circular loading indicator within the function itself.
Thank you for reviewing my contribution!
💻 Code Snippet