Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: Handle invalid API key on register-queue #1183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PIG208
Copy link
Member

@PIG208 PIG208 commented Dec 19, 2024

This is near term fix for a user-reported issue:
https://chat.zulip.org/#narrow/channel/48-mobile/topic/0.2E0.2E19.20Flutter.20.3A.20Cant.20connect.20to.20self.20hosted.20instance/near/2004042

It is not intended to be the full fix. With a better UX, we would bring the user back to the choose-account page without them manually doing so. That's covered by #737 but out-of-scope for this commit.

This partially addresses #890. It's sent individually because we want to at least handle that user-reported issue.

@PIG208 PIG208 requested a review from chrisbobbe December 19, 2024 22:04
@PIG208 PIG208 added the maintainer review PR ready for review by Zulip maintainers label Dec 19, 2024
@gnprice
Copy link
Member

gnprice commented Dec 20, 2024

Thanks!

Would you post a screenshot of what the error looks like? Then we can also wordsmith the error message.

@PIG208
Copy link
Member Author

PIG208 commented Dec 20, 2024

Sure!

image

@gnprice
Copy link
Member

gnprice commented Dec 20, 2024

Cool, thanks.

I think "Invalid API key" is probably too technical for this context. @alya do we have an appropriate message handy from elsewhere in the product?

@PIG208
Copy link
Member Author

PIG208 commented Dec 21, 2024

Perhaps we can rename and reuse the title string we have for login failure:

  "errorLoginCouldNotConnectTitle": "Could not connect",

This sort of feels like an instance of #741 the way we currently handle it, but this message will not be needed after #737.

screenshot

image

This is near term fix for a user-reported issue:
  https://chat.zulip.org/#narrow/channel/48-mobile/topic/0.2E0.2E19.20Flutter.20.3A.20Cant.20connect.20to.20self.20hosted.20instance/near/2004042

It is not intended to be the full fix.  With a better UX, we would
bring the user back to the choose-account page without them manually
doing so.  That's covered by zulip#737 but out-of-scope for this commit.

Signed-off-by: Zixuan James Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer review PR ready for review by Zulip maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants