Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing Whitelisted Protocols to User Settings #1401

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonassorgenfrei
Copy link

What's this PR do?

It exposes the whitelisted protocols list so users can add additional protocols that should not use the link wrapper.
Adresses Issue: #1284

You have tested this PR on:

  • Windows
  • Linux/Ubuntu

@jonassorgenfrei jonassorgenfrei changed the title implementing whitelisted protocols to allow configuring linkifiers in… Exposing Whitelisted Protocols to User Settings Dec 27, 2024
@alya
Copy link
Collaborator

alya commented Dec 27, 2024

Thanks! Could you please update your commit message to match the commit style guidelines?

@andersk
Copy link
Member

andersk commented Dec 27, 2024

Do not close and reopen multiple pull requests for the same thing, even to fix the commit structure; you can always fix the commit structure by rebasing and force-pushing your existing branch.

This commit exposes the whitelisted protocol list to the user
settings.json file. This allows user to extend or modify the list of
linkifiers that are directly opened by the os instead of being opened
via the redirect html method.
@jonassorgenfrei
Copy link
Author

I adjusted the commit message to match the style guide.
Yeah i messed i my repo on the first PR by directly implementing it on the main branch and by messing up my rebasing. Next time i know better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants