macOS: Show alternate tray icon for unread messages #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrinsmart
force-pushed
the
alt-tray-icon
branch
from
85f058e to
23d1f2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an alternate tray icon for macOS, which is displayed when there are unread messages.
Many Mac users set the dock to auto-hide in order to maximize screen area. Unfortunately this also hides the unread messages badge and makes it very hard to notice when there are new messages available.
But the menu bar is always visible, and the tray icon is a great way to show that there are unread messages. I can quickly glance up to the menu bar and see that messages are pending, then click that icon to bring Zulip to the foreground.
My graphic design skills are lacking so I simply used an opacity variation to differentiate the icons. This is probably worthy of discussion and I expect could be improved if anyone would like to contribute.
Menubar with unread messages:
Menubar with no unread messages:
The change only affects macOS clients. I've also tested on Linux, but not Windows.