readme: SETTING_EXTERNAL_HOST needs to contain a top level domain #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without it (e.g. if it's a dotless domain name like `mycomputer`), this results in an Internal Server Error page due to this line https://github.com/zulip/zulip/blob/81bd63cb46273b8c94ef9e92c00893ed97110119/zerver/models.py#L4904
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am setting up a Zulip instance in my home LAN, so at first tried setting
SETTING_EXTERNAL_HOST: "mypchostname:1234".However this resulted in an Internal Server Error page -- after inspecting the logs, it was due to this line https://github.com/zulip/zulip/blob/81bd63cb46273b8c94ef9e92c00893ed97110119/zerver/models.py#L4904
Seems that
FAKE_DOMAIN_NAMEisn't exposed for the docker setup, so I decided the easiest option for me was just to add an alias likemypchostname.lanin the hosts file.But it's a bit of a gotcha -- not sure whether it requires a proper fix, or worth exposing that FAKE_DOMAIN_NAME setting -- so figured at least mention in the docs might help some people.