-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate publishing multiarch images to GHCR (migrate away from Docker Hub) #397
base: main
Are you sure you want to change the base?
Conversation
Before I go making the changes to run this workflow using tags instead of the version file, saving this link to a successful CI run which generated this GHCR manifest |
d50c312
to
6889479
Compare
In light of recent changes to Docker Hub, move our Docker images into GHCR which integrates more tightly with GitHub flows we already use throughout the Zulip org. Since it's near-trivial to do so at the same time, add officiallly-supported ARM64 builds. Resolves #357.
6889479
to
4138977
Compare
# -- Pull policy for Zulip docker image. | ||
# Ref: https://kubernetes.io/docs/user-guide/images/#pre-pulling-images | ||
pullPolicy: IfNotPresent | ||
# -- Zulip image tag (immutable tags are recommended) | ||
tag: "6.1-0" | ||
tag: "6.1-1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now can't do this version bump without a tag, so it needs to come after the PR merges. The commit message needs top be massaged accordingly, I think.
@@ -86,7 +86,7 @@ spec: | |||
- name: postgresql-persistent-storage | |||
mountPath: /var/lib/postgresql | |||
- name: zulip | |||
image: zulip/docker-zulip:6.1-0 | |||
image: ghcr.io/zulip/zulip:6.1-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto above.
docker pull ghcr.io/zulip/zulip:6.1-1 | ||
``` | ||
|
||
- Current Zulip Server version: `6.1` | ||
- Current Docker image version: `6.1-1` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's leave these as 6.1-0 for now, and do a version bump tag separately.
Supercedes #390 by building multiarch images in GHCR rather than depending on local workstation builds.
Blockers: https://github.com/orgs/zulip/packages/container/package/zulip needs to be made public, and I need to verify that this repo actually has permissions to push to that registry (while I'm an admin of the registry, I'm not an admin of this repo, so can't double-check the secrets plumbing behind the scenes that I vaguely recall being a thing to do here).