Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECMAScript support #212

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ECMAScript support #212

wants to merge 7 commits into from

Conversation

Siilwyn
Copy link

@Siilwyn Siilwyn commented Jan 30, 2021

Each commit has a body with some more more information about the changes. Commit (a68b0f3) drops support for Node.js 10 making it a breaking change which might be possible to include in v2? It does decrease the package size since no CommonJS build output is packed anymore. Feel free to rebase or cherry pick some of the changes!

Also remove unofficial fields that mark a package as 'ES' and bump build
related tooling dependencies to ensure compatibility with the new
standard. Since the package scope is now set to module change config
files to use ESM or run with CommonJS using the `cjs` extension.

Closes zspecza#201
Also ensures that exactly the dependencies listed in the lock are used.
Prevents file listing from jumping in editors.
"build:es": "cross-env BABEL_ENV=es babel src --out-dir es --ignore **/*.test.js",
"build:unpkg": "cross-env BABEL_ENV=es rollup --config",
"codecov": "codecov",
"doctoc": "doctoc readme.md --title \"## Table of Contents\"",
"lint": "eslint .*rc.js *.js src/**/*.js --ignore-pattern '!.*rc.js'",
"lint": "eslint src/**/*.js",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't quite figure out how to include linting the CommonJS root files without ESLint throwing an error, hope this is okay.

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #212 (c0ce012) into master (d3f7042) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #212   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines          121       121           
  Branches        31        31           
=========================================
  Hits           121       121           
Impacted Files Coverage Δ
src/TemplateTag/TemplateTag.js 100.00% <ø> (ø)
src/commaLists/commaLists.js 100.00% <ø> (ø)
src/commaListsAnd/commaListsAnd.js 100.00% <ø> (ø)
src/commaListsOr/commaListsOr.js 100.00% <ø> (ø)
src/createTag/createTag.js 100.00% <ø> (ø)
src/html/html.js 100.00% <ø> (ø)
src/id/id.js 100.00% <ø> (ø)
...c/inlineArrayTransformer/inlineArrayTransformer.js 100.00% <ø> (ø)
src/inlineLists/inlineLists.js 100.00% <ø> (ø)
src/oneLine/oneLine.js 100.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f7042...c0ce012. Read the comment docs.

@Siilwyn
Copy link
Author

Siilwyn commented Feb 1, 2021

Today I noticed that directory imports (e.g. import x from './some-dir') do not work. A full path including extension is needed to work in vanilla Node.js.

@Siilwyn
Copy link
Author

Siilwyn commented Feb 3, 2021

Ready for review @fatfisz & @zspecza.

@Siilwyn
Copy link
Author

Siilwyn commented Jul 5, 2021

@fatfisz friendly ping! I've been running into problems with npm 7 and using git tarballs as a workaround for using this patch instead of the published npm package. Let me know if I can help with anything.

@Siilwyn
Copy link
Author

Siilwyn commented Feb 11, 2022

👋 @fatfisz hope you can find some time to review this PR soonish 🤞

@damianobarbati
Copy link

@Siilwyn repo is clearly dead. Should we simply fork the repo and re-publish on npm, with all of this merged?

@Siilwyn
Copy link
Author

Siilwyn commented Jun 17, 2022

Hey thanks for the idea @damianobarbati, I did email a bit with the author and he did have intentions to merge this but was very busy.
I'll look into forking soonish.

@Siilwyn
Copy link
Author

Siilwyn commented Sep 18, 2022

Okay it's happening! I've created https://github.com/Siilwyn/common-tagged and intend to publish it coming week. But just before that I'd like to see if there are other alternatives perhaps, @damianobarbati do you still use this package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants