Annotate functions with [[lifetimebound]] attribute where applicable.
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpogue
reviewed
Jan 10, 2025
| @@ -95,13 +95,13 @@ namespace _ST_PRIVATE | |||
| } | |||
|
|
|||
| ST_NODISCARD | |||
| inline const char *find_cs(const char *haystack, size_t size, char ch) | |||
| inline const char *find_cs(const char *haystack ST_LIFETIME_BOUND, size_t size, char ch) | |||
There was a problem hiding this comment.
Just checking, these annotations are intentionally on the parameter and not on the method?
There was a problem hiding this comment.
Yes, the return parameter is a reference to the same block of memory as the haystack variable.
dpogue
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #45