Switch GTest to use FetchContent rather than a submodule. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpogue
approved these changes
Oct 15, 2024
| include(FetchContent) | ||
| FetchContent_Declare(gtest | ||
| GIT_REPOSITORY https://github.com/google/googletest.git | ||
| GIT_TAG v1.15.2 |
There was a problem hiding this comment.
I seem to recall 1.14.x caused issues with one of the older compilers we were trying to support, which is why we were previously locked on 1.13.0.
Happy to use the latest, but just want to confirm that you're intentionally bumping the version up.
There was a problem hiding this comment.
The submodule was actually on 1.12.1, which is the last version to support C++11 (newer versions require C++14). I guess this technically means we'd be dropping support for C++11 for testing, but I think I'm fine with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, we avoid having to keep a copy of all the gtest code in the repo, but still avoid needing to deal with submodules.
Fixes #40
Supersedes #41