Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to add arguments on nginx-proxy docker run #948

Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

Allow to add arguments on nginx-proxy docker run #948

wants to merge 6 commits into from

Conversation

clesquir
Copy link

@clesquir clesquir commented May 23, 2018

e.g.:

proxy: {
   shared: {
        dockerArgs: [
            '-p 8080:8080'
        ]
    }
}

@zodern
Copy link
Owner

zodern commented Jul 16, 2018

Thanks for creating this @clesquir.

Two things:

  1. Since changing the docker arguments effects every app using the reverse proxy, it should be part of reconfigShared.
  2. Move the option to proxy.shared.dockerArgs.

Once #706 is implemented there will be an easier way to add ports, but this PR has many additional uses such as adding networks, volumes, using a custom nginx template, etc.

@clesquir
Copy link
Author

Please let me know if there is anything else to be modified!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants