Conversation
f6f4334 to
e0c9668
Compare
phillip-stephens
left a comment
There was a problem hiding this comment.
This is great, really appreciate this effort to get this functionality added.
I haven't fully dug into this, but I'm wondering if there's a non-secure mode that can be used as well. I added a dockerized RDP service (TEST_MODULES=rdp make integration-test) on local port 3389 (username = username, pwd = password) which works through the Microsoft RDP app but not with the scanner. I tried just a simple toggle off of TLS but looks like something deeper is going on.
I can circle back to this as I get some free time, but I think this would be good to add support for since we may be most interested in such un-secured RDP services.
modules/rdp/types.go
Outdated
| } | ||
|
|
||
| type RDPResult struct { | ||
| OSVersion string `json:"os_version,omitempty"` |
There was a problem hiding this comment.
I believe this is the RDP Version based on testing a couple known public IPs
| OSVersion string `json:"os_version,omitempty"` | |
| RDPVersion string `json:"rdp_version,omitempty"` |
There was a problem hiding this comment.
This is actually os_version.
Example:
10.0.17763 is:
https://learn.microsoft.com/en-us/windows/uwp/whats-new/windows-10-build-17763
Interesting, I'll try to poke at it this week too |
|
So, because I am using NTLM to get version information, this doesn't work for xrdp. |
|
I'm not sure how we feel about LLMs here, but I developed a set of changes with one in order to handle other RDP auth types. I added a test for no tls, but the other 3 mechanisms are windows specific, so appropriate containers not available. As a bonus, added NTLM detection for SMB as well, which I am more than happy to pull out and do a round of "what can we extract NTLM out of" as a seperate PR |
Break out NTLM into its own subobject, which is optional
5cfeb79 to
37ad4f7
Compare
Adds a module for RDP
At least a starting point for #17