Add Builtin trait and refactor all builtin functions to use it #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zedar
force-pushed
the
feat/builtins_trait
branch
from
f180506 to
2740b1a
Compare
|
Looks good, thanks! |
added 2 commits
January 13, 2025 15:19
Add Builtin trait and refactor all builtin functions to use it Refactor builtin function to Builtin trait Fix
zedar
force-pushed
the
feat/builtins_trait
branch
from
2740b1a to
116839a
Compare
|
@katat |
katat
approved these changes
Jan 14, 2025
| (ASSERT_FN, assert_fn, false), | ||
| (ASSERT_EQ_FN, assert_eq_fn, false), | ||
| (AssertEqFn::SIGNATURE, AssertEqFn::builtin, false), | ||
| (AssertFn::SIGNATURE, AssertFn::builtin, false), |
There was a problem hiding this comment.
Might be better to just return an array of structs with Builtin trait?
| Error::new( | ||
| pub trait Builtin { | ||
| const SIGNATURE: &'static str; | ||
|
|
There was a problem hiding this comment.
We can add a constant property SKIP_TYPE_CHECK: bool to indicate whether to type check this builtin signature and avoid the need to specify them within the get_fns function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses this issue #227.
Already merged with #238.