Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error when a keyword is used as identifier #239

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Improve error when a keyword is used as identifier #239

merged 1 commit into from
Dec 10, 2024

Conversation

zedar
Copy link

@zedar zedar commented Dec 3, 2024

This PR addresses this issue: #236

katat
katat approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@katat katat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@zedar
Copy link
Author

zedar commented Dec 4, 2024

Thanks @katat , will you merge it?

@mimoo
Copy link
Contributor

mimoo commented Dec 9, 2024

can you post a screenshot of the error?

@zedar
Copy link
Author

zedar commented Dec 9, 2024

There it is:
image

@mimoo
Copy link
Contributor

mimoo commented Dec 10, 2024

looks great thanks so much :) and nice terminal

@mimoo mimoo merged commit 321b047 into zksecurity:main Dec 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katat katat katat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zedar @mimoo @katat