Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MIMC stdlib #208

Merged
merged 10 commits into from
Oct 28, 2024
Merged

Add MIMC stdlib #208

merged 10 commits into from
Oct 28, 2024

Conversation

katat
Copy link
Collaborator

@katat katat commented Oct 23, 2024

  • Fix: Default constants to bigint type in order to allow larger literals in native code, such as the constant values in mimc.
  • Added MIMC stdlib(for a single input), but it requires the support of generic calls within forloop in order to support multi_mimc: allow generic calls within forloop #189

mimoo
mimoo reviewed Oct 25, 2024
View reviewed changes
src/mast/mod.rs
TyKind::Array(Box::new(self.resolve_type(ty, ctx)), val)
TyKind::Array(
Box::new(self.resolve_type(ty, ctx)),
val.to_u32().expect("array size exceeded u32"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use that UnexpectedError from #209 :o

mimoo
mimoo approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@mimoo mimoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katat katat merged commit 83e3491 into feat/init-stdlib Oct 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimoo mimoo mimoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katat @mimoo