refactor: bump to current Kimchi proof system revision #20
Conversation
|
Thanks for the PR! what prompted you to do this btw if I may ask :) ? working on anything interesting? |
| "package `{}` has neither a `lib.no` nor a `main.no` file. At least one of them is required"), | ||
| (false, true) if must_be_lib => miette::bail!("package `{user}/{repo}` is missing a `lib.no` file"), | ||
| "package has neither a `lib.no` nor a `main.no` file. At least one of them is required"), | ||
| (false, true) if must_be_lib => miette::bail!("package is missing a `lib.no` file"), |
There was a problem hiding this comment.
good catch, I'm wondering how that was compiling
|
can you run |
Hi David. I'm currently exploring folding schemes on Plonk with Sangria, and ultimately, the Kimchi proof system. I thank you very much for your language, as it is the perfect starting point for generating Plonk circuits. Merci :) |
|
Hello David, $ cargo run -- test --path examples/arithmetic.no --debug --private-inputs '{"private_input": ["1"]}' --public-inputs '{"public_input":["1"]}'
thread 'main' panicked at src/circuit_writer/mod.rs:307:13:
the circuit is either too small or does not constrain anything (TODO: better error)Why this constraint of 2 gates for Kimchi, by the way? Thanks David. |
|
Ah, there was some assumptions in kimchi that don't work with circuits that are too small, it's probably fixable but since people don't generally write small circuits like that we didn't. Now I'm wondering why Anyway thanks for the PR again! If you're interested there's more opportunities to contribute to this repo :D we also have a group chat for questions/discussions https://t.me/+VSChAOmJQgQzODcx |
|
ah clippy is not happy, well we should take care of that in another PR anyway. |
Description
This Pull Request (PR) aims at refactoring the current version of
Nonameso that it supports a more recent version of the Kimchi proof system.The present code compiles and executes successfully with revision a5d8883ddf649c22f38aaac122d368ecb9fa2230 of Kimchi.
All current tests passed and none (i.e. unit, integration or property-based tests) were added.
Type of change
Minor refactoring changes impacting mostly the
prover, witness and some cryptographic primitives.Test Configuration