Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ios bindings update action #886

Merged

Conversation

ElusAegis
Copy link
Contributor

  1. Fix an issue to allow to push new tags to the ezkl-swift-repo even if there are no changes to the bindings
  2. Fix an issue with workflow failing on automatic trigger by removing the automatic trigger

@ElusAegis
Copy link
Contributor Author

Right now we need to manually trigger the workflow to publish new version of swift package.

What we can do is add an automatic trigger for the workflow instead of the manual trigger that will run the workflow every time a new tag is created in the ezkl repo. Is this something we would prefer instead of manual updates?

@alexander-camuto
Copy link
Collaborator

Right now we need to manually trigger the workflow to publish new version of swift package.

What we can do is add an automatic trigger for the workflow instead of the manual trigger that will run the workflow every time a new tag is created in the ezkl repo. Is this something we would prefer instead of manual updates?

yes plz @ElusAegis

@ElusAegis ElusAegis force-pushed the fix/ios-bindings-update-action branch from c9a7824 to 703dbee Compare December 15, 2024 11:07
@ElusAegis
Copy link
Contributor Author

@alexander-camuto now the workflow runs when the new version tag is pushed

@alexander-camuto alexander-camuto merged commit c4354c1 into zkonduit:main Dec 16, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants