Feat/script tests #49
Merged
+392
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoraSuegami
reviewed
Sep 22, 2024
| ### Test for scripts | ||
|
|
||
| ```shell | ||
| pnpm test:script |
There was a problem hiding this comment.
Could you add --threads 1 to the test command because the tests for scripts might fail with multiple threads due to conflicts among env settings.
There was a problem hiding this comment.
@SoraSuegami pnpm test:script command already has this option.
There was a problem hiding this comment.
@SoraSuegami I've added thread 1 option to foundry.toml
SoraSuegami
changed the base branch from
feat/body-parsing
to
matter-labs-audit-fixes
|
@wshino Could you also fix the conflict? |
JohnGuilding
pushed a commit
that referenced
this pull request
Oct 8, 2024
* Remove email-wallet-sdk * Update package version * Update README * Update pnpm commands * Add tests for scripts * Add threads = 1 to foundry.toml
| * @dev Tests that deployment fails when both DKIM_REGISTRY and SIGNER environment variables are | ||
| * not set. | ||
| */ | ||
| function testFail_run_no_dkim_registry_no_signer() public { |
There was a problem hiding this comment.
testFail... may be deprecated in the future foundry-rs/foundry#4437. Don't think it is worth changing here now but FYI
| /** | ||
| * @dev Tests the deployment process when the DKIM_REGISTRY environment variable is not set. | ||
| */ | ||
| function test_run_no_dkim_registry() public { |
There was a problem hiding this comment.
Missing cases for no emailAuthImpl, validatorAddr and _factory?
| * @notice Tests the deployment and execution of the DeploySafeNativeRecovery script | ||
| * without a SIGNER configured. | ||
| */ | ||
| function test_run_no_signer() public { |
There was a problem hiding this comment.
Missing test cases for no emailAuthImpl and commandHandler
| /** | ||
| * @notice Tests the run function without a DKIM registry. | ||
| */ | ||
| function test_run_no_dkim_registry() public { |
There was a problem hiding this comment.
Missing test cases for no dkimRegistrySigner and emailAuthImpl?
| } | ||
|
|
||
| /// @notice Tests the deployment run without a DKIM registry | ||
| function test_run_no_dkim_registry() public { |
There was a problem hiding this comment.
Mising test cases for no emailAuthImpl and _factory
JohnGuilding
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Remove email-wallet-sdk * Update package version * Update README * Update pnpm commands * Add tests for scripts * Add threads = 1 to foundry.toml
SoraSuegami
added a commit
that referenced
this pull request
Nov 3, 2024
* Use ether-email-auth for body parsing * Replace "subject" with "command" * Enable test on any branch * chore: update .env.example * Update ether-email-auth * Update ether-email-auth * Update ether-email-auth * Update ether-email-auth * Import ether-email-auth as npm package * Add EmailRecoveryManagerZkSync * Update version * Fix EmailRecoveryManagerZkSync * Fix renaming * Fix remapping * Fix EmailRecoveryManagerZkSync * Fix README to replace "subject" with "command". * fix compile warnings & format * extract more logic to base test & rename variables * remove unnecessary vm.prank * Add more logic to base test & more linting * Remove email-wallet-sdk * Update package version * Add how to debug errors to README * Fix readme * Add a CREATE2_SALT argument to DeploySafeRecovery script * add guardian vote check & recovery hash to weight storage WIP * Improve RecoveryRequest * Fix all unit tests * Feat/script tests (#49) * Remove email-wallet-sdk * Update package version * Update README * Update pnpm commands * Add tests for scripts * Add threads = 1 to foundry.toml * Prevent malicious guardians threatening liveness via cooldown * Uncomment all test assertions & use EnumerableSet * Update processRecovery tests * Add remaining tests from TODOs & add getter fn * Update existing assertions with new state * Add getAllGuardians getter function * Make getter function view * 10 Critical events are not observable * Return false for canStartRecoveryRequest when threshold is zero * Update ether-email-auth * Update package version * 10. EmailRecoveryContract is not compatible with zkSync * clearRecoveryRequest properly in deinit * Update ether-email-auth-contracts * Update version to 0.0.10 * Update natpsec * test-nexus-account * Run tests with different command handlers * Rename * Add fuzz tests for hexToBytes32 unit tests * Add tests for AccountHidingRecoveryCommandHandler * Add safe module unit tests * fuzz test getPreviousOwnerInLinkedList * Add missing low risk functions * Add script for account hiding * Add the section which is how to solve errrors * Use ForwardDKIMRegistry * Remove ForwardDKIMRegistry * Fix failing tests * revert to all github workflows without nexus account * 13 EmailRecoveryManager delay can be set to zero * Fix failing test * Fix lock file * Recover lock file * Change workflow * Fix MockGroth16Verifier * Update depndency * Specify npm package of ether-email-auth * Use salt value for deployment (#55) * Use salt value for deployment * Add minimumDelay * Add CREATE2_SALT value into all deploy scripts * Update depndencies * Fix bug from updating modulekit * Use StringUtils from ether-email-auth * 0.0.12-preview * 0.0.12 * Add kill switch functionality (#58) * Add support section (#57) * update @zk-email/ether-email-auth-contracts * Update scripts * Update scripts * Fix script * Fix script * Add a new script --------- Co-authored-by: Aditya Bisht <[email protected]> Co-authored-by: JohnGuilding <[email protected]> Co-authored-by: wshino <[email protected]> Co-authored-by: John Guilding <[email protected]>
This was referenced Dec 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
made test cases for scripts except for Deploy7579TestAccount.s.sol