-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using prelude rather than ecs::xyz in derive #99
Conversation
@@ -15,11 +15,11 @@ homepage = "https://github.com/zkat/big-brain" | |||
[workspace] | |||
|
|||
[dependencies] | |||
bevy = { version = "0.13.0", default-features = false } | |||
bevy = { version = "0.13.2", default-features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it's customary to bump these minor versions in libraries. Local setups usually handle choosing the right version. not sure though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for comment. I will happily revert if indeed bad pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally and it looks like it works with either 0.13.0 or 0.13.2. Again, not sure if bad pattern or not, just something I might've seen/heard elsewhere
I reproduced your initial issue and verified these changes fixed it for me |
Ah, so, I can verify that the change to the import path has nothing to do with it. The fix is to make sure that the Bevy version used by Big Brain match the Bevy version used by the user code. So, with latest Bevy 0.13 and latest Big Brain 0.19, there is a mismatch - as Big Brain 0.19 uses Bevy 0.12. Thus the compiler saying "found a different Commands" - it's from a semantically different Bevy dependency. In my user code, I simply specify the Big Brain dependency using a git location - as the main:HEAD of this project is on Bevy 0.13 - and the error evaporates, the example builds successfully, and everything works. Really bottom line just points to releasing Big Brain 0.20 including Bevy 0.13, imho. |
The compiler message could be more clear, I think is the real answer... |
No description provided.