Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): support md5 salted for imported password hashes #9596

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

mtrisc
Copy link
Contributor

@mtrisc mtrisc commented Mar 20, 2025

Which Problems Are Solved

Allow verification of imported salted passwords hashed with plain md5.

How the Problems Are Solved

  • Upgrade passwap to v0.7.0
  • Add md5salted as a new verifier option in defaults.yaml

Additional Changes

  • go version and libraries updated (required by passkey v0.7.0)
  • secrets.md verifiers updated
  • configuration verifiers updated
  • added MD5salted and missing MD5Plain to test cases

Additional Context

# Which Problems Are Solved

Allow verification of imported salted passwords hashed with plain md5.

# How the Problems Are Solved

- Upgrade passwap to
[v0.7.0](https://github.com/zitadel/passwap/releases/tag/v0.7.0)
- Add md5salted as a new verifier option in `defaults.yaml`
Copy link

vercel bot commented Mar 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 21, 2025 11:01am

@hifabienne hifabienne added the os-contribution This is a contribution from our open-source community label Mar 20, 2025
@muhlemmer muhlemmer self-requested a review March 21, 2025 10:12
@muhlemmer muhlemmer enabled auto-merge (squash) March 21, 2025 10:50
@muhlemmer
Copy link
Collaborator

@mtrisc thanks for the complete PR! 😄. If you'd like to have a small gift in return, please send us a mail to hi@zitadel.com. We will send you a form with questions about your address and shirt size.

@muhlemmer muhlemmer merged commit e4c1286 into zitadel:main Mar 21, 2025
26 checks passed
@mtrisc mtrisc deleted the crypto-md5salted branch March 21, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os-contribution This is a contribution from our open-source community
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants