-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(permissions): system user support for permission check v2 #9460
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks for your contribution @kkrime! 🎉Please make sure you tick the following checkboxes before marking this Pull Request (PR) as ready for review:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9460 +/- ##
===========================================
+ Coverage 39.00% 63.36% +24.35%
===========================================
Files 1547 1627 +80
Lines 148805 152867 +4062
===========================================
+ Hits 58044 96859 +38815
+ Misses 86219 51144 -35075
- Partials 4542 4864 +322
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b144835
to
2947c07
Compare
…for permission check v2
…upport for permission check v2
a4648ad
to
601327f
Compare
… user support for permission check v2
… system user support for permission check v2
…ddeding system user support for permission check v2
…ons): Addeding system user support for permission check v2
…ermissions): Addeding system user support for permission check v2
… feat(permissions): Addeding system user support for permission check v2
… fixup! feat(permissions): Addeding system user support for permission check v2
… fixup! fixup! feat(permissions): Addeding system user support for permission check v2
… fixup! fixup! fixup! feat(permissions): Addeding system user support for permission check v2
…branch 'main' into syste-users-permissions
@@ -30,7 +30,7 @@ services: | |||
|
|||
db: | |||
restart: 'always' | |||
image: 'cockroachdb/cockroach:latest-v24.3' | |||
image: 'cockroachdb/cockroach:latest' | |||
command: 'start-single-node --insecure --http-addr :9090' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@livio-a I need to make this change otherwise it starts complaining about a unsupported feture in my sql scripts in the e2e browser
pipeline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it doesn't work with cockroach, we need to make sure it's only released as part of v3 (target branch for that is v3.x
)
… Merge branch 'main' into syste-users-permissions
This reverts commit 96cf271.
This reverts commit 4bc7b0a.
Replaced by #9640 |
Which Problems Are Solved
For permissoin check v2, we currently check the human users permissions from the DB, however for system users (from the config, which would not be in the DB), their permissions are not in the DB, but are in a config file like defaults.yaml.
How the Problems Are Solved
The way the permissions work are based on the following:
https://zitadel.slack.com/archives/C087ADF8LRX/p1742207808062949?thread_ts=1742206770.965909&cid=C087ADF8LRX
Additional Changes
Important to note from this point onwards, System Users permissions will be picked up from
SystemAuthz
(added todefault.yaml
) NOTInternalAuthz