Reproducer for #3144 #3214
Draft
Reproducer for #3144 #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guizmaii
force-pushed
the
reproducer_3144
branch
from
d5f5c14 to
2fd301a
Compare
guizmaii
force-pushed
the
reproducer_3144
branch
from
2fd301a to
a9ab6fe
Compare
guizmaii
commented
Nov 19, 2024
| for { | ||
| response <- api.runZIO(makeRequest(body)) | ||
| body <- response.body.asString | ||
| } yield assertTrue(body == """{"no":"body"}""") |
There was a problem hiding this comment.
Fails with:
- OptionalBodySpec / accepts empty body - 78 ms
✗ "{\"name\":\"MalformedBody\",\"message\":\"Malformed request body failed to decode: Unexpected end of input\"}" was not equal to "{\"no\":\"body\"}"
body == """{"no":"body"}"""
body = "{\"name\":\"MalformedBody\",\"message\":\"Malformed request body failed to decode: Unexpected end of input\"}"
at /Users/jules/jules_ivanic/workspace/zio-http/zio-http/jvm/src/test/scala/zio/http/endpoint/OptionalBodySpec.scala:57
guizmaii
force-pushed
the
reproducer_3144
branch
from
eb979ef to
c6ffc8d
Compare
guizmaii
force-pushed
the
reproducer_3144
branch
from
c6ffc8d to
fa5c9f7
Compare
guizmaii
commented
Nov 19, 2024
Comment on lines
+425
to
+428
| val isOptional = EnvironmentTag[Input2] <:< EnvironmentTag[Option[?]] | ||
| println(s"==================== Is optional: $isOptional ==================== ") | ||
| copy(input = input ++ (if (isOptional) codec.optional.asInstanceOf[zio.http.codec.HttpCodec[zio.http.codec.HttpCodecType.RequestType,Input2]] else codec)) | ||
| } |
There was a problem hiding this comment.
I attempted a fix here but the result is that it makes fail the only test which was passing and the test which was failing still fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3144
The issue seems to be that for a
Schema[Option[A]]we need to create aHttpContentCondec.fromSchema(Schema[A]).optional