[gen] adding support for "Any" and "AnyObject" as json in codegen #3205
+255
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hochgi
commented
Nov 12, 2024
| @@ -1077,7 +1078,10 @@ final case class EndpointGen(config: Config) { | |||
| ), | |||
| ) | |||
| case JsonSchema.Null => throw new Exception("Null query parameters are not supported") | |||
| case JsonSchema.AnyJson => throw new Exception("AnyJson query parameters are not supported") | |||
| case JsonSchema.AnyJson => { | |||
| // throw new Exception("AnyJson query parameters are not supported") | |||
There was a problem hiding this comment.
why did we previously throw exception?
Am I breaking some other validation now?
There was a problem hiding this comment.
@987Nabil any idea regarding this one?
There was a problem hiding this comment.
- Please no
{}block for a case handling :) - The exception was that there is no handling implemented. Not that there can't be one
Noneseems odd. Can you explain?
There was a problem hiding this comment.
- sure, will do
- the exception refers to query parameters, so that was weiird.
- the method is
def schemaToCode(…): Option[Code.File], there is no need to generate a file forJson. It's just an import. SoNonewas obvious to me.
hochgi
commented
Nov 12, 2024
zio-http/shared/src/main/scala/zio/http/endpoint/openapi/JsonSchema.scala
Outdated
Show resolved
Hide resolved
hochgi
commented
Nov 12, 2024
| eats: {} | ||
| extra_attributes: | ||
| type: object | ||
| additionalProperties: true |
There was a problem hiding this comment.
should also test for all the 3 out of 4 possible cases we handle?
extra_attributes:
type: object
additionalProperties: true
extra_attributes:
type: object
additionalProperties: {}
extra_attributes:
additionalProperties: trueThere was a problem hiding this comment.
Sorry, help me out. This dynamic fields open api always confuses me
There was a problem hiding this comment.
this is straight out of the docs:
hochgi
force-pushed
the
gen-issue-3199-support-any-and-any-object-as-json
branch
from
d4ef6d4 to
afe0bce
Compare
987Nabil
reviewed
Dec 2, 2024
| @@ -1077,7 +1078,10 @@ final case class EndpointGen(config: Config) { | |||
| ), | |||
| ) | |||
| case JsonSchema.Null => throw new Exception("Null query parameters are not supported") | |||
| case JsonSchema.AnyJson => throw new Exception("AnyJson query parameters are not supported") | |||
| case JsonSchema.AnyJson => { | |||
| // throw new Exception("AnyJson query parameters are not supported") | |||
There was a problem hiding this comment.
- Please no
{}block for a case handling :) - The exception was that there is no handling implemented. Not that there can't be one
Noneseems odd. Can you explain?
| eats: {} | ||
| extra_attributes: | ||
| type: object | ||
| additionalProperties: true |
There was a problem hiding this comment.
Sorry, help me out. This dynamic fields open api always confuses me
| MetaData.KeySchema( | ||
| fromSerializableSchema(keySchema), | ||
|
|
||
| val definedAttributesCount = schema.productIterator.count(_.asInstanceOf[Option[_]].isDefined) |
There was a problem hiding this comment.
One thing I learned from the zio http open api integration: I hate it and open API is a crap format haha 😂
hochgi
force-pushed
the
gen-issue-3199-support-any-and-any-object-as-json
branch
from
afe0bce to
2640057
Compare
hochgi
force-pushed
the
gen-issue-3199-support-any-and-any-object-as-json
branch
from
7007e5c to
feedb58
Compare
logic properly handles correctly these cases:
extra_attributes:
type: object
additionalProperties: true
extra_attributes:
type: object
additionalProperties: {}
extra_attributes:
additionalProperties: true
but fails for this case, which might not be an issue (or an issue with zio-schema):
extra_attributes:
additionalProperties: {}
Also, small code re-arranges to avoid:
"Exhaustivity analysis reached max recursion depth, not all missing cases are reported."
compile error due to too many cases in pattern match.
hochgi
force-pushed
the
gen-issue-3199-support-any-and-any-object-as-json
branch
from
feedb58 to
b81551c
Compare
987Nabil
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/fixes #3199
/claim #3199