This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Add a channel that outputs to a subscriber. #360
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to replace the current
subscriber.toZIOSink
with a channel. The advantage of a channel is that it is notified of upstream errors and can propagate them to the subscriber'sonError
method. While a channel is generally not as convenient to use as a sink, I think it is more convenient than the current sink + error handler pairing, asScope
to be exposed to the callerSo this:
becomes:
For the API, I've followed the
ZChannel
convention instead of the existing style. ForZChannel
the way "to" and "from" are used is different. For example, there'sZSink.fromQueue
which means "create a sink from this queue", whereas the channel equivalent isZChannel.toQueue
which means "create a channel that outputs to this queue". We could definitely dosubscriber.toZIOChannel
instead or in addition though.Edit: I just changed it to propagate upstream errors in addition to signalling
onError
to the subscriber. Seems desirable? So the output error isSome(throwable)
for an upstream error andNone
for cancellation by the subscriber.