Case normalize #1027
Open
Case normalize #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalgoyal
requested changes
Feb 7, 2025
| @@ -0,0 +1,88 @@ | |||
| package zingg.common.core.preprocess.caseNormalize; | |||
There was a problem hiding this comment.
java packages should have all lowercase. we messed up at infraForTest but lets follow the convention
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public abstract class CaseNormalizer<S,D,R,C,T> implements IMultiFieldPreprocessor<S,D,R,C,T> { |
There was a problem hiding this comment.
better to break it down into one abstract class AMultiFieldPreproc and then extend it. So other multi preprocs would not need to define any of the getter setters
|
|
||
| @Override | ||
| public boolean isApplicable() { | ||
| return true; |
There was a problem hiding this comment.
should return true only when you have string fields
| List<String> stringFields = new ArrayList<>(); | ||
| for (FieldDefinition fieldDefinition : fieldDefinitions) { | ||
| if (fieldDefinition.dataType != null && fieldDefinition.matchType != null && | ||
| fieldDefinition.dataType.equalsIgnoreCase(STRING_TYPE) && !fieldDefinition.matchType.contains(MatchTypes.DONT_USE)) { |
There was a problem hiding this comment.
lets discuss this. so far we have always abstracted dataType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.