[tei]fix: correct indentation for extraEnv and volumeMounts using nindent #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@haorenfsa Thanks for the review, good guy. |
|
@siyu77 sry for the delay on my side. Please sign-off your commit before we could merge it https://github.com/zilliztech/milvus-helm/pull/223/checks?check_run_id=43655566461 |
haorenfsa
approved these changes
Jun 25, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haorenfsa, siyu77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Replaced `indent` with `nindent` in Helm templates for: - `extraEnv` variables - `volumeMounts` declarations Ensures proper YAML formatting by: 1. Starting blocks on new lines 2. Maintaining consistent 8-space indentation 3. Preventing indentation errors in generated manifests Signed-off-by: siyu77 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
indentwithnindentin Helm templates for:extraEnvvariablesvolumeMountsdeclarationsEnsures proper YAML formatting by:
What this PR does / why we need it:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])