Merge pull request #33 from zgreen/warning/quiet-from-to

quiet PostCSS from/to warning
zgreen · Sep 23, 2018 · 655a06e · 655a06e
2 parents 2fe9f2c + 6496435
commit 655a06e
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 11 deletions.
diff --git a/example/example.js b/example/example.js
@@ -8,7 +8,7 @@ const basePath = `${process.cwd()}/example`
 function cb (files) {
   function useFileData (data, file) {
     postcss([postcssCriticalCSS({ outputPath: basePath })])
-      .process(data)
+      .process(data, { from: undefined, to: undefined })
       .then(result => {
         fs.writeFile(
           `${basePath}/${file.split('.')[0]}.non-critical.css`,

diff --git a/lib/index.js b/lib/index.js
@@ -177,7 +177,12 @@ function buildCritical() {
       criticalOutput[cur].each(function (rule) {
         return criticalCSS.append(rule.clone());
       });
-      return (0, _postcss2.default)(minify ? [_cssnano2.default] : []).process(criticalCSS).then(dryRunOrWriteFile.bind(null, dryRun, filePath)).then(clean.bind(null, css, preserve));
+      return (0, _postcss2.default)(minify ? [_cssnano2.default] : [])
+      // @TODO Use from/to correctly.
+      .process(criticalCSS, {
+        from: undefined,
+        to: undefined
+      }).then(dryRunOrWriteFile.bind(null, dryRun, filePath)).then(clean.bind(null, css, preserve));
     }, {});
   };
 }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "postcss-critical-css",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Generate critical CSS using PostCSS",
   "main": "index.js",
   "repository": {

diff --git a/src/index.js b/src/index.js
@@ -94,8 +94,9 @@ function dryRunOrWriteFile (
   result: Object
 ): Promise<any> {
   const { css } = result
-  return new Promise((resolve: Function): void =>
-    resolve(dryRun ? doDryRun(css) : writeCriticalFile(filePath, css))
+  return new Promise(
+    (resolve: Function): void =>
+      resolve(dryRun ? doDryRun(css) : writeCriticalFile(filePath, css))
   )
 }
 
@@ -164,13 +165,19 @@ function buildCritical (options: Object = {}): Function {
       (init: Object, cur: string): Function => {
         const criticalCSS = postcss.root()
         const filePath = path.join(outputPath, cur)
-        criticalOutput[cur].each((rule: Object): Function =>
-          criticalCSS.append(rule.clone())
+        criticalOutput[cur].each(
+          (rule: Object): Function => criticalCSS.append(rule.clone())
+        )
+        return (
+          postcss(minify ? [cssnano] : [])
+            // @TODO Use from/to correctly.
+            .process(criticalCSS, {
+              from: undefined,
+              to: undefined
+            })
+            .then(dryRunOrWriteFile.bind(null, dryRun, filePath))
+            .then(clean.bind(null, css, preserve))
         )
-        return postcss(minify ? [cssnano] : [])
-          .process(criticalCSS)
-          .then(dryRunOrWriteFile.bind(null, dryRun, filePath))
-          .then(clean.bind(null, css, preserve))
       },
       {}
     )