[zend-rest] update zend-rest deps according to usage #192
Conversation
packages/zend-rest/composer.json
Outdated
| "ext-dom": "*", | ||
| "ext-reflection": "*", | ||
| "ext-simplexml": "*", | ||
| "zf1s/zend-controller": "^1.15.3", |
There was a problem hiding this comment.
could we keep zend-controller in suggest, please? It's required only by Zend_Rest_Controller and Zend_Rest_Route. So it's optional when only client/server classes are used.
There was a problem hiding this comment.
This was indeed a close call. I myself only use Zend_Rest_Controller and Zend_Rest_Route (and not the client/server classes). Both uses are indeed completely separate. suggest sounds better.
There was a problem hiding this comment.
@falkenhawk Can all other deps also be moved to suggest? With the exception of Zend_Exception. That makes sense when using only the MVC classes (Zend_Rest_Controller and Zend_Rest_Route).
There was a problem hiding this comment.
@falkenhawk I'm not sure what you meant with the eyes emoji :) I won't move the others in this PR for now.
packages/zend-rest/composer.json
Outdated
| } | ||
| }, | ||
| "suggest": { | ||
| "zf1s/zend-config": "Used in special situations or with special adapters" |
There was a problem hiding this comment.
Zend_Config is not used at all - can be removed from suggest. Type hinting an instance of Zend_Config in Zend_Rest_Route::getInstance() does not make the class/package itself required.
There was a problem hiding this comment.
Just so I understand: the type hinting, if not installed, won't lead to an error?
Or you mean type hinting-only use is not enough to make it required?
falkenhawk
changed the title
smhg
force-pushed
the
fix-zend-rest-deps
branch
from
b6732a5 to
69706d6
Compare
|
@falkenhawk I think this should be fine to merge now too? |
2 participants
@falkenhawk this is the last component (at least for now). Thanks!