throw() -> noexcept #623
Merged
throw() -> noexcept #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only deprecated in 17 and removed in 20 according to https://en.cppreference.com/w/cpp/language/noexcept_spec. pugixml doesn’t require C++11 so this will need to be guarded appropriately. |
|
@zeux - ironically the same site shows C++11/C++17 here, but what you've found matches my experience: https://en.cppreference.com/w/cpp/language/except_spec I've used the gated form. |
That’s referring to a non-empty throw specification which had a different deprecation schedule. |
|
PUGIXML_NOEXCEPT should be defined as throw() for builds to pass I believe. |
This is necessary to avoid gcc warnings for exception::what()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
throw()was deprecated in C++11 and removed in C++17.noexceptis the appropriate fix.