gltfpack: Use UTF-8 encoding during gltfpack processing #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When main() is used, the inputs are ANSI according to the current code page; this is fine if the file paths can be converted to ANSI, but may fail to open some files and will use ANSI file paths inside .gltf files which violates glTF specification. This can be worked around by using UTF8 as ANSI code page via a manifest; however, to avoid having to bundle a manifest we can also convert the command line arguments to UTF8 and set UTF8 as the codepage instead. This requires Windows 10 1803; on earlier Windows versions setlocale should silently fail so this should be more or less equivalent to the previous code.
|
This can also be solved with a manifest (https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page) and a couple of changes in CMakeLists.txt it looks like; will test this tomorrow as an alternative. |
zeux
force-pushed
the
gltf-utf8
branch
2 times, most recently
from
cc8822d
to
75b4a57
Compare
Since CMake supports manifest files as sources, it's a little easier to specify UTF-8 as the ANSI encoding via that; this is embedded into .exe and is used for command line arguments as well so the rest of the code just works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When main() is used, the inputs are ANSI according to the current code page; this is fine if the file paths can be converted to ANSI, but may fail to open some files and will use ANSI file paths inside .gltf files which violates glTF specification.
This can be worked around by using UTF8 as ANSI code page via a manifest; however, to avoid having to bundle a manifest we can also convert the command line arguments to UTF8 and set UTF8 as the codepage instead.
This requires Windows 10 1803; on earlier Windows versions setlocale should silently fail so this should be more or less equivalent to the previous code.
Fixes #767