set rpath when installing libzmq to be bundled #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auditwheel only fixes RPATH when it's defined, so make sure it's defined seems like a bug in auditwheel, but this is easy enough for us
1 task
rjmello
added a commit
to globus/globus-compute
that referenced
this pull request
Aug 21, 2024
Version 26.1.1 of `pyzmq` manually sets the LDFLAGS environment variable during the `libzmq` installation process, causing installation failures on some systems. To prevent these issues, we set the upper bound for `pyzmq` to 26.1.0 until `pyzmq` developers resolve the bug. Ref: zeromq/pyzmq#2014
rjmello
added a commit
to globus/globus-compute
that referenced
this pull request
Aug 21, 2024
Version 26.1.1 of `pyzmq` manually sets the LDFLAGS environment variable during the `libzmq` installation process, causing installation failures on some systems. To prevent these issues, we set the upper bound for `pyzmq` to 26.1.0 until `pyzmq` developers resolve the bug. Ref: zeromq/pyzmq#2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
auditwheel only fixes RPATH in bundled libs when it's defined (pypa/auditwheel#451), so make sure it's defined.
seems like a bug in auditwheel, but this is easy enough for us to deal with.
closes #2013