Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: CI build android on ubuntu-latest failed #4726

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

githejie
Copy link
Contributor

Solution: Fixed the NDK version to android-ndk-r25 to avoid using unsupported NDK version on ubuntu-latest.

Fixes #4725

@stephan57160
Copy link
Contributor

stephan57160 commented Aug 16, 2024

I think I modified this variable initialization, to allow NDK configuration, as per development need.
Temporarily, this (or something similar) should help :

export NDK_VERSION=android-ndk-r25c
export ANDROID_NDK_ROOT=<my_prefered_ndk_root>
./ci_build.sh

Given NDK will/should be downloaded automatically during the build, if not already available.
At least, this was the goal...

I add @benjdero, as he might have some other fix pending for another issue with NDK 25.

@stephan57160
Copy link
Contributor

Solution: Fixed the NDK version to android-ndk-r25 to
avoid using unsupported NDK version on ubuntu-latest.
@githejie
Copy link
Contributor Author

Hi @stephan57160, thanks for your comment.

I previously specified the NDK version in ci_build.sh because I thought ci_build.sh was specifically for GitHub action, and users would use build.sh for local builds.

After considering your comment, I think it is more reasonable to use environment variables in CI.yaml to specify the NDK version.

@stephan57160
Copy link
Contributor

I previously specified the NDK version in ci_build.sh because I thought ci_build.sh was specifically for GitHub action, and users would use build.sh for local builds.

It was like this previously, yes.
But it was a nightmare to have ZYRE, CZMQ and LIBZMQ in sync regarding NDK versions.

@benjdero
Copy link
Member

This seems to be the right solution 👍

@bluca bluca merged commit 4c6cff6 into zeromq:master Aug 16, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI build android on ubuntu-latest failed
4 participants