Open
Conversation
…ract has been deployed on a given address
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the "mirror" feature to enable mirroring of contracts from one blockchain to others while refactoring some command option handling. Key changes include:
- Removing the deprecated field from chain definitions and filtering it out in getSupportedChains.
- Introducing a new command options module and updating the CLI's fluent API for improved command configuration.
- Implementing a new "mirror" command and corresponding action that fetches contract creation details from Etherscan and redeploys the contract on target chains.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/constant.ts | Removed the deprecated field and its usage in chain filtering. |
| src/command/options.ts | Added common command options and extended the Command API. |
| src/command/index.ts | Refactored command option handling and added the mirror command. |
| src/action/mirror.ts | Introduced the new mirror feature logic with contract mirroring. |
Comments suppressed due to low confidence (1)
src/command/index.ts:43
- The CommandOption type is redefined in this file although it is already exported from options.ts. Consider importing CommandOption from './options.js' to reduce duplication and improve maintainability.
type CommandOption = { flags: string; description: string; defaultValue?: string | boolean | string[] | undefined }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6