drivers: i2c: dw: Enable PINCTRL conjuction with dt prop 'pinctrl-0' #83371
Conversation
drivers/i2c/Kconfig.dw
Outdated
| @@ -5,7 +5,7 @@ menuconfig I2C_DW | |||
| bool "Design Ware I2C support" | |||
| default y | |||
| depends on DT_HAS_SNPS_DESIGNWARE_I2C_ENABLED | |||
| select PINCTRL if DT_HAS_RASPBERRYPI_PICO_I2C_ENABLED | |||
| select PINCTRL if $(dt_compat_any_has_prop,$(DT_COMPAT_I2C_DW),pinctrl-0) | |||
There was a problem hiding this comment.
The compatible is called snps,designware-i2c, so maybe you should check something like DT_COMPAT_SNPS_DESIGNWARE_I2C?
There was a problem hiding this comment.
This is an IP core that is used by multiple SoCs. Some of them do not have pinctrl, so we need to check.
There was a problem hiding this comment.
This is an IP core that is used by multiple SoCs. Some of them do not have pinctrl, so we need to check.
Yeah, that's for sure. I've done the same for the DW SPI core. My only point is the specific compatible name, which is used to generate the variable you're trying to use.
There was a problem hiding this comment.
Ah, I got it. It was still a draft, not yet tested. Thank you.
There was a problem hiding this comment.
It worked fine with applying your point. Thank you.
If there is a pinctrl-0 property, PINCTRL will be enabled in conjunction with it. Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
dw_i2c_pinctrl_enable_by_prop
branch
from
0554984 to
ab4baa1
Compare
If there is a pinctrl-0 property, PINCTRL will be enabled in conjunction with it.