Bluetooth: Classic: Gap: add link mode policy handle code #83350
+198
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth Host
area: Bluetooth Classic
zephyrbot
requested review from
alwa-nordic,
cvinayak,
hermabe,
jhedberg,
lylezhu2012,
rugeGerritsen,
sjanc,
Thalley and
theob-pro
|
@jhedberg In our Bluetooth service, there is a power manager module similar to Android that uses these interfaces power_manager.c |
|
By the way, general classic Bluetooth products such as headphones use these interfaces to manage SOC power consumption. |
lylezhu2012
requested changes
Dec 24, 2024
Frozen935
force-pushed
the
gap_upstream
branch
from
36bc2cd to
d1ab728
Compare
lylezhu2012
requested changes
Dec 25, 2024
| cp->handle = sys_cpu_to_le16(conn->handle); | ||
| cp->max_interval = sys_cpu_to_le16(max_interval); | ||
| cp->min_interval = sys_cpu_to_le16(min_interval); | ||
| cp->attempt = sys_cpu_to_le16(attempt); |
There was a problem hiding this comment.
The range of attempt is 1 to Tsniff÷2. I think the range of attempt also need to be checked.
There was a problem hiding this comment.
Tsniff(interval) is a negotiation results, here given a suggestion range from 1~0x1F3, some platform attempt is a fixed value 2 or 4.
How to deal with this more reasonably.
Add bt_conn_enter_sniff_mode/bt_conn_exit_sniff_mode api control the sniff mode, handle BT_HCI_EVT_MODE_CHANGE event to notify the host that the mode has been changed and link_mode_changed callback to notify application. Signed-off-by: fangzhenwei <[email protected]>
Frozen935
force-pushed
the
gap_upstream
branch
from
d1ab728 to
fdc19ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bt_conn_enter_sniff_mode/bt_conn_exit_sniff_mode api control the sniff mode, handle BT_HCI_EVT_MODE_CHANGE event to notify the host that the mode has been changed and link_mode_changed callback to notify application.