entropy: rpi_pico: implement entropy driver for RP2350 #83346
+90
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Crypto / RNG
platform: Raspberry Pi Pico
xudongzheng
force-pushed
the
rp2350-entropy-pr
branch
from
4468894 to
df8de81
Compare
Use get_rand_64() from Pico SDK for entropy. Signed-off-by: Xudong Zheng <[email protected]>
xudongzheng
force-pushed
the
rp2350-entropy-pr
branch
from
df8de81 to
be3cfa0
Compare
soburi
reviewed
Dec 25, 2024
| @@ -151,6 +151,18 @@ if(CONFIG_HAS_RPI_PICO) | |||
| zephyr_include_directories_ifdef(CONFIG_PICOSDK_USE_CLAIM | |||
| ${common_dir}/hardware_claim/include) | |||
|
|
|||
| zephyr_library_sources_ifdef(CONFIG_PICOSDK_USE_RAND | |||
| ${rp2_common_dir}/hardware_timer/timer.c | |||
| ${rp2_common_dir}/pico_rand/rand.c | |||
There was a problem hiding this comment.
This code uses pico-sdk's spin-lock feature, not zephyr's one.
I think it can't use as is.
We need to implements zephyr's own TRNG driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use get_rand_64() from Pico SDK for entropy.
This is somewhat based on #66764.