samples: net: sockets: echo_service: Use ZVFS default settings #83340
+0
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sample works without increasing ZVFS_OPEN_MAX and ZVFS_POLL_MAX to some arbitrary number. This also removes a duplicate entry for ZVFS_OPEN_MAX. ZVFS_OPEN_MAX already defaults to a reasonably large value of 16 if POSIX_API is enabled, which is the case for the echo_service sample. Signed-off-by: Marc Lasch <[email protected]>
zephyrbot
added
area: Sockets
zephyrbot
requested review from
jukkar,
kartben,
nashif,
pdgendt,
rlubos,
ssharks and
tbursztyka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Remove custom ZVFS Kconfig settings in favor of defaults.
This sample works without increasing ZVFS_OPEN_MAX and ZVFS_POLL_MAX to some arbitrary number. This also removes a duplicate entry for ZVFS_OPEN_MAX.
ZVFS_OPEN_MAX already defaults to a reasonably large value of 16 if POSIX_API is enabled, which is the case for the echo_service sample.
This was tested with a
native_sim/native/64andqemu_x86/atombuild and the telnet command from the readme and logging enabled. With the defaults settings for ZVFS_OPEN_MAX and ZVFS_POLL_MAX no errors are logged. Errors only occur when ZVFS_POLL_MAX is set to 2.