cmake: use project name instead of hardcoded name #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3zd3z
approved these changes
Dec 11, 2024
|
So, I think this is a good idea, but it is causing every single CI test to fail. I think you'll also need to fix the app name in every Cargo.toml file in the tree. |
jpeeters
force-pushed
the
fix-use-project-name-instead-of-hardcoded
branch
from
d8862c8 to
5b99e0c
Compare
This commit offers to give an arbitrary name to the Rust application project under CMake. Indeed, before this commit, the CMake project for the Rust application had the name `librustapp`. Now, it can be set with any value.
jpeeters
force-pushed
the
fix-use-project-name-instead-of-hardcoded
branch
from
5b99e0c to
5094c50
Compare
d3zd3z
reviewed
Dec 20, 2024
| @@ -1,6 +1,6 @@ | |||
| sample: | |||
| description: Hello world, but in Rust | |||
| name: hello rust world | |||
| name: hello world | |||
There was a problem hiding this comment.
I'll be real curious about this. At one point, I ran into twister failures if there were two samples, across the whole system, that had the same name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit offers to give an arbitrary name to the Rust application project under CMake.
Indeed, before this commit, the CMake project for the Rust application had the name
librustapp. Now, it can be set with any value.