hal: renesas: rz: Initial support for PWM #60
+2,615
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial HAL support for PWM Signed-off-by: Hieu Nguyen <[email protected]> Signed-off-by: Nhut Nguyen <[email protected]>
KhiemNguyenT
requested review from
KhiemNguyenT,
thaoluonguw and
duynguyenxa
duynguyenxa
approved these changes
Dec 23, 2024
thaoluonguw
reviewed
Dec 23, 2024
| #define GPT_CFG_PARAM_CHECKING_ENABLE (BSP_CFG_PARAM_CHECKING_ENABLE) | ||
| #define GPT_CFG_OUTPUT_SUPPORT_ENABLE (1) | ||
| #define GPT_CFG_WRITE_PROTECT_ENABLE (0) | ||
| #define GPT_CFG_GPTCLK_BYPASS 1 |
There was a problem hiding this comment.
@nhutnguyenkc : Please recheck define for "GPT_CFG_GPTCLK_BYPASS" whether it is as your expectation or not.
As my checking, it always checks with "BSP_FEATURE_BSP_HAS_GPT_CLOCK", and current BSP_FEATURE_BSP_HAS_GPT_CLOCK = 0 for rzg3s.
There was a problem hiding this comment.
@thaoluonguw , I understand your concern. I have checked the MDF and see that the 1 is fixed for GPT_CFG_GPTCLK_BYPASS of RZ/G3S. I don't think I can change this value since it can make the driver malfunction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial HAL support for PWM