Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal: renesas: rzg: Initial support for Interrupt Control #57

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nhutnguyenkc
Copy link
Contributor

Initial HAL support for Interrupt Control

Copy link
Collaborator

@thaoluonguw thaoluonguw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

Comment on lines 8 to 10
#ifdef __cplusplus
extern "C" {
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhutnguyenkc , Please recheck the code alignment here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@duynguyenxa , I have fixed the alignment. Please help me check again.

Comment on lines 14 to 16
#ifdef __cplusplus
}
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the alignment. Please help me check again.

Comment on lines 8 to 10
#ifdef __cplusplus
extern "C" {
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the alignment. Please help me check again.

Comment on lines 14 to 16
#ifdef __cplusplus
}
#endif
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the alignment. Please help me check again.

Initial HAL support for Interrupt Control

Signed-off-by: Hoang Nguyen <[email protected]>
Signed-off-by: Nhut Nguyen <[email protected]>
@nhutnguyenkc nhutnguyenkc force-pushed the support_renesas_rzg_intc branch from 1aaef19 to 5c637c3 Compare December 25, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants