wifi: build with no blobs #358
Open
+1,513
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvioalves
commented
Nov 3, 2024
| endif() | ||
| endforeach() | ||
| endif() | ||
|
|
There was a problem hiding this comment.
Zephyr already checks for blobs presence, making this unused.
marekmatej
reviewed
Nov 4, 2024
zephyr/port/wifi/wifi_stubs.c
Outdated
| #include "utils/includes.h" | ||
| #include "utils/common.h" | ||
|
|
||
| /* ################################# */ |
There was a problem hiding this comment.
can we replace this comment line with something more descriptive if that is needed?
sylvioalves
force-pushed
the
enh/wifi_build_only_mode
branch
from
2bc9c60
to
ff1df75
Compare
Add Wi-Fi stubs to allow CI build that does not required binary blobs. It is useful to test Wi-Fi driver and adapter. Signed-off-by: Sylvio Alves <[email protected]>
sylvioalves
force-pushed
the
enh/wifi_build_only_mode
branch
from
ff1df75
to
90505fc
Compare
wmrsouza
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Wi-Fi stubs to allow CI build that does not
required binary blobs. It is useful to test
Wi-Fi driver and adapter.